Fix skip link underline being removed when global styles are enabled #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
force-pushed
the
fix-skip-link-underline-global-styles
branch
from
38ebfd2 to
de8aec6
Compare
querkmachine
force-pushed
the
fix-skip-link-underline-global-styles
branch
from
de8aec6 to
bbc74c6
Compare
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for bbc74c6 |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/components/skip-link/_index.scss b/packages/govuk-frontend/dist/govuk/components/skip-link/_index.scss
index 9ca6fde4b..9c4803617 100644
--- a/packages/govuk-frontend/dist/govuk/components/skip-link/_index.scss
+++ b/packages/govuk-frontend/dist/govuk/components/skip-link/_index.scss
@@ -27,6 +27,7 @@
// Undo unwanted changes when global styles are enabled
@if $govuk-global-styles {
+ @include govuk-link-decoration;
box-shadow: none;
}
}
Action run for bbc74c6 |
Merged
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4930.
Changes
govuk-link-decorationmixin (which sets thetext-decoration,text-decoration-thicknessandtext-decoration-offsetproperties) to the list of styles re-added to the Skip link component when global styles are enabled.Thoughts
text-decoration: underlinedoesn't have the desired effect, as thetext-decoration: noneinherited from the global styles also resets the thickness and offset properties. We do need all three.